etseidl commented on code in PR #10149:
URL: https://github.com/apache/arrow-rs/pull/10149#discussion_r3429042683
##########
parquet/src/file/writer.rs:
##########
@@ -236,14 +236,25 @@ impl<W: Write + Send> SerializedFileWriter<W> {
self.assert_previous_writer_closed()?;
let ordinal = self.row_group_index;
- let ordinal: i16 = ordinal.try_into().map_err(|_| {
+ // Thrift cannot encode lists with more than 2B elements
Review Comment:
2 billion, i32::MAX. I can make that clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
