alamb commented on code in PR #10126:
URL: https://github.com/apache/arrow-rs/pull/10126#discussion_r3431315058
##########
arrow-flight/src/encode.rs:
##########
@@ -671,7 +666,7 @@ fn prepare_schema_for_flight(
fn split_batch_for_grpc_response(
batch: RecordBatch,
max_flight_data_size: usize,
-) -> Vec<RecordBatch> {
+) -> impl Iterator<Item = RecordBatch> {
Review Comment:
I thought this PR was for a benchmark, but this is more than just a
benchmark -- isn't this part of another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
