Copilot commented on code in PR #50220:
URL: https://github.com/apache/arrow/pull/50220#discussion_r3437501972
##########
r/tests/testthat/test-duckdb.R:
##########
@@ -123,13 +123,17 @@ test_that("to_duckdb then to_arrow", {
)
# Now check errors
+ # dbplyr 2.6.0 added "con" to the allowed $ fields on tbl_lazy;
+ # older versions only allow "src" and "lazy_query"
+ skip_if(packageVersion("dbplyr") < "2.6.0")
+
Review Comment:
Avoid skipping this error-path test for dbplyr < 2.6.0. Since `arrow` only
Suggests dbplyr without a minimum version, this test file can be run with older
dbplyr versions; `skip_if(packageVersion("dbplyr") < "2.6.0")` drops coverage
unnecessarily. Instead, branch on the dbplyr version and override either
`ds_rt$src$con` (old dbplyr) or `ds_rt$con` (dbplyr >= 2.6.0) so the expected
error is exercised across versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
