fangchenli opened a new pull request, #50224:
URL: https://github.com/apache/arrow/pull/50224
### Rationale for this change
Grouper rejected `string_view` and `binary_view` group keys with
`NotImplemented: Keys of type string_view`, so `Table.group_by` on a view-typed
key failed.
### What changes are included in this PR?
- Add `BinaryViewKeyEncoder` in `row_encoder_internal.{h,cc}`. It encodes
view keys using the existing variable-length row format and decodes them into a
fresh view array of the original type.
- `GrouperImpl::Make` dispatches view keys to the new encoder.
- `GrouperFastImpl::CanUse` rejects view keys, so they fall back to
GrouperImpl.
### Are these changes tested?
Yes, unit tests added.
### Are there any user-facing changes?
Yes. `Table.group_by` now accepts `string_view` and `binary_view` group keys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
