kou commented on code in PR #50214:
URL: https://github.com/apache/arrow/pull/50214#discussion_r3439991437
##########
cpp/src/gandiva/precompiled/time.cc:
##########
@@ -270,9 +270,10 @@ static const int WEEK_LEN[] = {6, 6, 7, 9, 8, 6, 8};
}
\
}
\
if (dateSearch == 0) {
\
- std::string err_msg = "NEXT_DAY: '" + std::string(in, in_len) +
\
- "' is not a recognized day of the week";
\
- gdv_fn_context_set_error_msg(context, err_msg.c_str());
\
+ char err_msg[128];
\
+ snprintf(err_msg, sizeof(err_msg),
\
+ "NEXT_DAY: '%.*s' is not a recognized day of the week", in_len,
in); \
Review Comment:
Ah, long message will be just truncated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
