kou commented on code in PR #1189:
URL: https://github.com/apache/arrow-java/pull/1189#discussion_r3447756263
##########
.github/workflows/test.yml:
##########
@@ -66,7 +67,7 @@ jobs:
uses: actions/cache@v5
with:
path: .docker
- key: maven-${{ matrix.jdk }}-${{ matrix.maven }}-${{
hashFiles('compose.yaml', '**/pom.xml', '**/*.java') }}
+ key: maven-${{ matrix.jdk }}-${{ matrix.maven }}-${{
hashFiles('compose.yaml', '**/pom.xml') }}
Review Comment:
Why is this needed?
If we don't update a cache by `.java` change, I think that we can't reuse
cache for changed `.java`.
##########
.github/workflows/test.yml:
##########
@@ -149,59 +152,111 @@ jobs:
integration:
name: AMD64 integration
runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
timeout-minutes: 60
steps:
+ - name: Check integration relevance
+ id: integration-changes
+ uses: actions/github-script@v8
+ with:
+ script: |
+ if (context.eventName !== 'pull_request') {
+ core.setOutput('should_run', 'true');
+ return;
+ }
+
+ const files = await github.paginate(
+ github.rest.pulls.listFiles,
+ {
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ pull_number: context.payload.pull_request.number,
+ per_page: 100,
+ }
+ );
+
+ const relevant = files.some(({ filename }) =>
+ filename === 'compose.yaml' ||
+ filename === 'pom.xml' ||
+ filename === '.github/workflows/test.yml' ||
+ filename.startsWith('c/') ||
+ filename.startsWith('flight/') ||
+ filename.startsWith('format/') ||
+ filename.startsWith('vector/') ||
+ filename.startsWith('ci/scripts/') ||
+ filename.startsWith('testing/data/') ||
+ filename.endsWith('/pom.xml')
+ );
Review Comment:
Let's separate this job to another workflow and use `paths:`
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onpushpull_requestpull_request_targetpathspaths-ignore
.
If you work on this as a separated PR, we'll be able to merge this PR sooner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
