alamb commented on code in PR #10142:
URL: https://github.com/apache/arrow-rs/pull/10142#discussion_r3451760031
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -2094,6 +2105,82 @@ mod tests {
assert_eq!(read_values, values);
}
+ /// The dictionary page is routed through the [`PageStore`] like any other
+ /// page rather than held resident in memory, so a dictionary column
chunk's
+ /// *entire* serialized size — dictionary page included — passes through
the
+ /// store.
+ #[test]
+ fn dictionary_page_is_routed_through_the_store() {
+ /// A store that sums the bytes handed to `put`.
Review Comment:
there is some non trivial overlap with the existing RecordingPageStore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
