haohuaijin commented on issue #10140: URL: https://github.com/apache/arrow-rs/issues/10140#issuecomment-4769439529
I completely agree. The goal of this PR is to help callers that already have a bitmap avoid one extra conversion, both for performance and memory usage. In that case, `BooleanBuffer -> RowSelector -> mask` is unnecessary overhead. I also agree that current DataFusion paths do not naturally produce bitmap-backed `RowSelection`s, so this PR should not be described as a broad DataFusion / TPC-DS / ClickBench improvement. Tomorrow I will update the issue and PR descriptions to make the scope clearer, and add an example/benchmark for the intended use case, such as an external index, FTS index, or bitmap index producing a bitmap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
