alamb opened a new pull request, #10180: URL: https://github.com/apache/arrow-rs/pull/10180
# Which issue does this PR close? n/a — a small standalone test-coverage improvement. # Rationale for this change `test_get_batch` in `parquet/src/util/bit_util.rs` only exercised the unsigned types (`u8`/`u16`/`u32`/`u64`). `BitReader::get_batch` is also generic over the signed integer types (`i8`/`i16`/`i32`/`i64`) and `bool`, each with its own `FromBitpacked` implementation, but none of those were covered by the test. This matters because `parquet` is **not** part of the MIRI CI workflow (which only covers the `arrow-*` crates), so there is no machine-checked coverage of those `get_batch` code paths today. This gap is especially relevant alongside work like #10172, which routes the signed types through a distinct (reinterpreting) code path. # What changes are included in this PR? Extend `test_get_batch` to also run the signed counterpart of each width and `bool` (at its only supported bit width of 1), reusing the existing `test_get_batch_helper`. # Are these changes tested? This PR is itself test-only. Verified locally with both `cargo test` and `cargo miri test` for `util::bit_util`. # Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
