lidavidm commented on pull request #10230: URL: https://github.com/apache/arrow/pull/10230#issuecomment-839952344
Thanks for the reviews. I think I've addressed all feedback, minus the shared_ptr<OutputStream> - while this is weird, it is the pattern used by IPC and Parquet as well and I think we may was well be consistent across the formats. (Also, IPC exposes both the output-owning and output-borrowing APIs too, even though it expects the caller to close the stream in both cases.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
