pepijnve commented on code in PR #10161:
URL: https://github.com/apache/arrow-rs/pull/10161#discussion_r3465013247
##########
arrow-string/src/concat_elements.rs:
##########
@@ -221,6 +221,158 @@ pub fn concat_elements_fixed_size_binary(
Ok(result.finish())
}
+struct ConcatByteViewBuilder<T>
+where
+ T: ByteViewType,
+{
+ views: Vec<u128>,
+ data: Vec<u8>,
+ inline: Vec<u8>,
+ phantom: PhantomData<T>,
Review Comment:
No strong opinion on this one. It might results in a slightly smaller binary
indeed. Would you prefer this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
