alamb commented on code in PR #9494:
URL: https://github.com/apache/arrow-rs/pull/9494#discussion_r3469548298
##########
arrow-json/test/data/mixed_arrays.json:
##########
@@ -1,4 +0,0 @@
-{"a":1, "b":[2.0, 1.3, -6.1], "c":[false, true], "d":4.1}
Review Comment:
> I've removed this rule because the JSON reader can't actually do this
coercion, so I figured it was better to error out instead.
I don't understand -- on main `test_json_infer_schema` read this file and
inferred its schema as
```rust
let schema = Schema::new(vec![
Field::new("a", DataType::Int64, true),
Field::new("b", list_type_of(DataType::Float64), true),
Field::new("c", list_type_of(DataType::Boolean), true),
Field::new("d", list_type_of(DataType::Utf8), true),
]);
```
What is not supported about this?
##########
arrow-json/test/data/mixed_arrays.json:
##########
@@ -1,4 +0,0 @@
-{"a":1, "b":[2.0, 1.3, -6.1], "c":[false, true], "d":4.1}
Review Comment:
I mean in general, if this PR causes inference that previously used to work
to start failing, I am not sure we would want to merge it
BY removing hte tests, it is harder to evaluate what effective behavior
change in this PR is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
