taepper commented on code in PR #50248:
URL: https://github.com/apache/arrow/pull/50248#discussion_r3473200947
##########
cpp/src/arrow/compute/kernels/vector_sort_internal.h:
##########
@@ -106,382 +106,315 @@ int CompareTypeValues(Value&& left, Value&& right,
SortOrder order,
}
template <typename IndexType>
-struct GenericNullPartitionResult {
- IndexType* non_nulls_begin;
- IndexType* non_nulls_end;
- IndexType* nulls_begin;
- IndexType* nulls_end;
+struct GenericPartitionResultByNullLikeness {
Review Comment:
Yes, that is definitely sensible, I like removing the `Result` from the name
as it is used to store that `Partition` in various places.
`NullPartitionResult` sort of implied it is only used as a single-use struct
which is only returned by a `NullPartition` function.
Having `NullPartition`, `NanPartition` (as helpers), and `NullLikePartition`
for the total struct sounds great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
