pepijnve opened a new pull request, #10222: URL: https://github.com/apache/arrow-rs/pull/10222
# Which issue does this PR close? None; relates to https://github.com/apache/datafusion/pull/23211 # Rationale for this change `concat_elements_fixed_size_binary` supports concatenation of `FixedSizeBinary(n)` and `FixedSizeBinary(m)`, but the guard clause in `concat_elements_dyn` prevents this from actually being possible with `dyn Array`. # What changes are included in this PR? Adjust the guard clause in `concat_elements_dyn` to allow concatenation of mixed `FixedSizeBinary` types. # Are these changes tested? - Added an extra test case for mixed `FixedSizeBinary` specifically - Adjusted the existing unit tests to use `concat_elements_dyn`. This maintains coverage of the functions that were being called (since they're still called indirectly) while increasing the coverage `concat_elements_dyn` # Are there any user-facing changes? Yes, the pre conditions of the function are relaxed. This should not be a breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
