Benjamin-Philip commented on code in PR #68:
URL: https://github.com/apache/arrow-erlang/pull/68#discussion_r3498142584
##########
.github/workflows/docs.yml:
##########
@@ -83,8 +70,70 @@ jobs:
- name: Upload artifact
uses: actions/upload-pages-artifact@v5
with:
+ name: docs-${{ github.sha }}
path: 'doc'
- - name: Deploy to GitHub Pages
- id: deployment
+ gh_pages:
+ # Only deploy on a push to main
+ if: github.ref_name == 'main' && github.event_name == 'push'
Review Comment:
> But can we close it...?
You'd have to disable GitHub Pages from the settings.
> Yes. Because it will confuse users.
We can take it down if you insist, but I think GitHub Pages could be used to
serve docs from main, while we use asf-site for releases? Also it's always
useful to have multiple mirrors in case one fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
