fallintoplace opened a new pull request, #870: URL: https://github.com/apache/arrow-go/pull/870
### What changed NewSliceData now rejects negative start and end bounds before constructing sliced Data metadata. ### Why The existing bounds check rejected end positions past the array length and start positions after the end, but it did not reject negative bounds. A call such as NewSliceData(data, -1, 0) could produce a Data value with a negative offset even though the function documents that out-of-range slices panic. ### Validation - go test ./arrow/array -run TestNewSliceDataInvalidBounds -count=1 - go test ./arrow/array -count=1 - PARQUET_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/parquet-testing/data ARROW_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/arrow-testing/data go test ./... -count=1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
