balicat commented on PR #285: URL: https://github.com/apache/arrow-dotnet/pull/285#issuecomment-4877558237
Updated per review: - Restored the original single-parameter constructors and added explicit `ArrowContext` overloads — binary compatibility preserved - `CallInvoker` path: private two-arg constructor + public static `FlightClient.Create(CallInvoker, ArrowContext)` factory, keeping DI resolution unambiguous - Added `TestIntegrationWithGrpcNetClientFactoryAndArrowContext` exercising the factory via `ConfigureGrpcClientCreator`, as suggested - While in there: `DoExchange` wasn't passing the client's `ArrowContext` to its response stream reader (compressed exchange responses couldn't decompress) — fixed All 56 Flight + 88 Flight.Sql tests passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
