alamb commented on pull request #288: URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840491188
I am not opposed to the idea of `StatefulFunction` but it seems like a large overkill for the now() function. Here is an alternate proposal (in https://github.com/apache/arrow-datafusion/pull/335): https://github.com/apache/arrow-datafusion/commit/261e76982178dfcc723aa9b2842e7b4d1d4a4b87 -- basically use a closure to capture the value for now() during plan time. It doesn't require changing any other function signatures and I think implements the semantics of `now()` correctly. What do you think @msathis @jorgecarleitao @Dandandan and @returnString ? If we still want to do `StatefulFunction` that is cool too, but perhaps it would better be done as part of another PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
