Copilot commented on code in PR #50401:
URL: https://github.com/apache/arrow/pull/50401#discussion_r3533067490
##########
c_glib/arrow-flight-glib/server.cpp:
##########
@@ -1196,6 +1197,19 @@ gaflight_server_servable_get_raw(GAFlightServable
*servable)
}
G_BEGIN_DECLS
+static void
+gaflight_server_dispose(GObject *object)
+{
+ auto priv = GAFLIGHT_SERVER_GET_PRIVATE(object);
+
+ if (priv->options) {
+ g_object_unref(priv->options);
+ priv->options = nullptr;
+ }
+
Review Comment:
Releasing `priv->options` in `dispose()` can free the auth handler while the
underlying Flight server (and its gRPC threads) may still be alive until
`priv->server` is destructed in `finalize()`. That reintroduces a potential
use-after-free during teardown if the server is still handling calls. Keep the
options reference until after the embedded `gaflight::Server` is destroyed (or
ensure the server is shut down before unref’ing options).
##########
.github/workflows/ruby.yml:
##########
@@ -135,7 +135,7 @@ jobs:
macos:
name: ARM64 macOS GLib & Ruby
- runs-on: macos-latest
+ runs-on: macos-26
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
Review Comment:
This job is labeled “ARM64 macOS …” but `runs-on: macos-26` doesn’t specify
architecture, unlike other workflows in this repo (e.g., `python.yml` uses
`macos-15-intel` and `macos-14`). If the intent is to reproduce
`macos-26-arm64` failures, consider using an explicit ARM64 runner label (or a
matrix similar to other workflows) to avoid accidentally running on the wrong
architecture when runner defaults change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
