fornwall opened a new pull request, #4471: URL: https://github.com/apache/arrow-adbc/pull/4471
The build detected sqlite3_load_extension() availability with a plain-text search of sqlite3.h. That heuristic is unreliable: the identifier also appears in comments and inside blocks guarded by SQLITE_OMIT_LOAD_EXTENSION, so the symbol can be textually present in the header yet not actually declared/linkable. Apple's system SQLite is built with load extension omitted, so the search matched but sqlite.cc then failed to compile with "use of undeclared identifier 'sqlite3_load_extension'". This started failing when the macos-latest (Apple Silicon) CI runner image was rolled to one whose SQLite omits the function; the string search never detected the omission. Replace it with a real compile+link probe using CheckSymbolExists, matching how the R package's configure script already detects the same thing. Closes #4470. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
