cmettler commented on code in PR #284: URL: https://github.com/apache/arrow-dotnet/pull/284#discussion_r3539323616
########## src/Apache.Arrow.Serialization/Apache.Arrow.Serialization.csproj: ########## @@ -0,0 +1,20 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <TargetFramework>net8.0</TargetFramework> Review Comment: the library now targets netstandard2.0;net462;net8.0 (matching Apache.Arrow), with tests passing on both net8.0 (197) and net472 (182 — the gap is only DateOnly/TimeOnly/Half, which don't exist there). To make that possible, IArrowSerializer<T> changed from static abstract members (which require the .NET 8+ runtime) to an instance interface resolved through a generated, module-initializer-populated registry — the MessagePack IMessagePackFormatter<T> pattern — so the public extension API is identical on every TFM, still reflection-free and AOT-safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
