mdekstrand commented on issue #1002: URL: https://github.com/apache/arrow-rs/issues/1002#issuecomment-4916448946
@alamb The `parquet_derive` Cargo manifest still lists `parquet` as a dependency: https://github.com/apache/arrow-rs/blob/52920f946cf8aa038d04fe432e77889f8253b7ce/parquet_derive/Cargo.toml#L34-L38 I also re-built my project with the current `parquet_derive` as well as upgraded Rust (in case there was a relevant Rust / Cargo change), and I am no longer seeing `parquet` show up twice in the compiling list, but still seeing two compiled versions of Parquet under `target/debug/deps`. I'm not sure the extent to which this is a feature-selection issue: the `parquet_derive` crate depends on the `parquet` crate with default features, and I might not have been using default features for my own `parquet` dependency when I originally filed the bug. The default-feature dependency for `parquet_derive` also means that the macro package also pulls in Arrow as a dependency. In any case, I think it would be helpful to review whether `parquet_derive` actually needs to depend on `parquet`. Since macros operate at a purely syntactic level, it is very possible that the derive macros can do everything they need without an actual `parquet` dependency. If it still does need the `parquet` dependency, does it need the full default feature set including Arrow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
