zeroshade commented on PR #909: URL: https://github.com/apache/arrow-go/pull/909#issuecomment-4928587825
Heads-up on overlap with #910: the map-key error-propagation changes here — `getMapKey` returning `(protoreflect.Value, error)`, the `protobufMapKeyValuePairResult` channel wrapper, `getDataType` skipping errored pairs, and the contextual error in `AppendValueOrNull` — are identical to what #910 already contains. #910 stacks the oneof/union nil-safety fix on top of exactly these changes, so it's effectively a strict superset and the two will conflict on merge. Suggestion: close this in favor of #910. If you'd rather keep them separate for reviewability, the alternative is to merge #909 first and rebase #910 onto it — but folding into #910 seems cleanest. The code here is correct either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
