unikdahal commented on PR #4465: URL: https://github.com/apache/arrow-adbc/pull/4465#issuecomment-4929135046
> The test doesn't fail even if I revert the change in FlightSqlConnection. The tests I added were just basic checks that resources get freed and are not specifically testing the double-close fix itself. For a test that actually covers the fix: is it okay if I use reflection here to swap in a fake client that counts close() calls, or would you rather I add a seam for it instead? @lidavidm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
