raulcd commented on code in PR #50486:
URL: https://github.com/apache/arrow/pull/50486#discussion_r3568873328
##########
.github/workflows/pr_review_trigger.yml:
##########
@@ -26,6 +26,7 @@ jobs:
# workflow. We trigger a new workflow run which will have permissions to add
labels.
label-when-reviewed:
name: "Label PRs when reviewed"
+ if: github.event.review.user.type != 'Bot'
Review Comment:
we can try but doesn't this still require the manual approval? I would have
thought this check is done once the workflow starts executing, hence the
permissions have been cleared. To be fair is not entirely clear from the
documentation:
https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_review
> When a first-time contributor submits a pull request to a public
repository, a maintainer with write access may need to approve running
workflows on the pull request. For more information, see [Approving workflow
runs from
forks](https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
