korowa opened a new pull request, #10330: URL: https://github.com/apache/arrow-rs/pull/10330
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> -- # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Current version of the tool works only with column names, so in case of reading a file with e.g. multiple array columns, the only option it provides is to run smth like ```sh parquet-index myfile.parquet element ``` and this will allow to display index stats for the first array column in the file. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> This patch includes two changes: - Make `parquet-index` accept full column paths (e.g. `mycolumn.list.element`), like `parquet-show-bloom-filter` tool already does. - Replace file offsets with decimal replesentations rather than hex representations, as it's not memory addresses, so likely the numbers will give more info in this case. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> Added an integration test for the `parquet-index` tool, and `parquet-show-bloom-filter` already has a test coverage. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> These are backwards incompatible changes for `parquet-index` tool, as now it requires full column name instead of leaf column name (nothing changes for simple cases when column path = column name) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
