Arawoof06 commented on code in PR #50463:
URL: https://github.com/apache/arrow/pull/50463#discussion_r3576141168
##########
cpp/src/gandiva/gdv_function_stubs_test.cc:
##########
@@ -1202,6 +1202,23 @@ TEST(TestGdvFnStubs, TestTranslate) {
EXPECT_STREQ(result, "");
EXPECT_THAT(ctx.get_error(),
::testing::HasSubstr("Would overflow maximum output size"));
+
Review Comment:
Added it. New case maps a matched input char to a `to` that ends in a
truncated 0xE2 lead byte, so the pre-patch build over-reads TO by 2 bytes (ASAN
READ of size 3) and the clamp passes it through as the single byte. Covers the
third fix now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
