Jefffrey commented on PR #10324: URL: https://github.com/apache/arrow-rs/pull/10324#issuecomment-4967960727
i'll need to think on this a little; i dont think having a separate `validate_utf8` flag would solve this as there would still be the loophole of exhibiting UB via completely safe APIs. marking as `unsafe` is the "easiest" fix but it seems unfortunate to do this when its for quite an edge case (indeed the docs for the base64 crate states that almost no one should need to implement `Engine` 🤔) another solution could be to change the return type to be a binary array instead of a string array, since it then pushes the utf8 validation onto the user, though it seems also a clunky solution 🙁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
