vlaurent1 commented on issue #4507: URL: https://github.com/apache/arrow-adbc/issues/4507#issuecomment-4968199430
Thanks for the quick responses folks! I re-ran on Windows with the nightly v1.12.0 (main `9be0298`) against 21 DECIMAL128 + 10 DECIMAL256 cases. Bug still on Windows (MSVC hits the slow path). All values where integer part >= 10^9 with non-zero fraction are corrupted — 12/21 DECIMAL128 and 6/10 DECIMAL256 on my Windows test. DECIMAL256 is also affected on every platform since no fast path exists for it. The remaining bug is in `GroupIntegerDigits()` at `writer.h:703-705` — the "Skip trailing zeros" guard drops zero base-10000 digit groups, shifting the weight and displacing fractional digits. Fix is probably to remove that guard and always insert every digit group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
