mzabaluev commented on code in PR #10331:
URL: https://github.com/apache/arrow-rs/pull/10331#discussion_r3578653254
##########
arrow-select/src/coalesce.rs:
##########
@@ -583,6 +583,22 @@ impl BatchCoalescer {
pub fn next_completed_batch(&mut self) -> Option<RecordBatch> {
self.completed.pop_front()
}
+
+ /// Get the number of bytes this struct use
Review Comment:
```suggestion
/// Returns the number of bytes used by this data structure.
```
##########
arrow-select/src/coalesce/generic.rs:
##########
@@ -32,8 +32,14 @@ use arrow_schema::ArrowError;
pub(crate) struct GenericInProgressArray {
/// The current source
source: Option<ArrayRef>,
+
+ /// Is [`Self::source`] is referenced in [`Self::buffered_arrays`]
Review Comment:
```suggestion
/// Is [`Self::source`] referenced in [`Self::buffered_arrays`]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
