fallintoplace opened a new pull request, #943:
URL: https://github.com/apache/arrow-go/pull/943

   ### Rationale for this change
   
   The generated and SIMD unpackers ignored short-read failures. SIMD code 
could access an empty buffer or decode stale pooled bytes, while the generated 
path could report a complete batch filled partly from zero values.
   
   ### What changes are included in this PR?
   
   Require each packed group to be read completely before decoding, return 
unpacking errors to `BitReader`, and avoid invoking SIMD routines unless the 
full input is present. The pooled SIMD buffers are retained without exposing 
partial contents to assembly.
   
   ### Are these changes tested?
   
   Yes. Every bit width from 1 through 32 is tested with a one-byte-truncated 
batch for both values and dictionary indexes. The suite passes with the normal 
implementation and with `-tags noasm`.
   
   ### Are there any user-facing changes?
   
   Truncated packed values now return an error instead of producing fabricated 
output or panicking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to