Jefffrey commented on code in PR #10327:
URL: https://github.com/apache/arrow-rs/pull/10327#discussion_r3585483958
##########
parquet_derive/src/parquet_field.rs:
##########
@@ -299,28 +312,25 @@ impl Field {
// becomes a column named `type` in the parquet schema
let field_name = self.ident.unraw().to_string();
let physical_type = match self.ty.physical_type() {
- parquet::basic::Type::BOOLEAN => quote! {
+ PhysicalType::Boolean => quote! {
::parquet::basic::Type::BOOLEAN
},
- parquet::basic::Type::INT32 => quote! {
+ PhysicalType::Int32 => quote! {
::parquet::basic::Type::INT32
},
- parquet::basic::Type::INT64 => quote! {
+ PhysicalType::Int64 => quote! {
::parquet::basic::Type::INT64
},
- parquet::basic::Type::INT96 => quote! {
- ::parquet::basic::Type::INT96
Review Comment:
makes sense to remove if it was already unreachable, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
