thisisnic commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-841058739


   > @thisisnic ooh we finally have some benchmark results to look at!: 
[ursa-i9-9960x 
(mimalloc)](https://conbench.ursa.dev/compare/runs/139601ccb33e49c88e039fcfa1a6d460...1a688615902f4a0a997f48e908738a25/)
   > The `dataframe-to-table` results are the pertinent ones here I think.
   > @jonkeane can you help us interpret these results?
   
   I'm going to take a stab at interpreting them just to see how I do.  
Overall, the changes I've made have made things 5% slower.  I'm not sure 
whether this is important - as I don't have a good idea of a cut-off, or idea 
whether any of this is just noise.  Looking more closely at the results, the 
biggest differences are to file-read, where the update is at least 8% slower.
   
   Does this feel like a significant slowdown? I'd say so.  I think it provides 
support to the idea that this really should be implemented at the C++ level 
rather than the R level.  Is this OK to be merged in? I think "perhaps", as 
long as we open a JIRA for this to be implemented at the C++ level.
   
   Let me know your thoughts!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to