Rich-T-kid commented on PR #10317: URL: https://github.com/apache/arrow-rs/pull/10317#issuecomment-4983657438
>it would be good to preserve some of the useful comments as it looks like theyre getting lost in the port Ill add the comments back in > are there any downstream concerns with replacing what we previously did (calling handle_alloc_error()) with just an error and relying on downstream to properly handle im not sure. I think the best person to ask would be @alamb. from the docs for [handle_alloc_error](https://doc.rust-lang.org/beta/std/alloc/fn.handle_alloc_error.html) > it may either panic (resulting in unwinding or aborting as per configuration for all panics), or abort the process (with no unwinding). it seems that once this branch is hit there isn't much for the process to do anyway? in both cases it aborts the process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
