etseidl commented on code in PR #10364:
URL: https://github.com/apache/arrow-rs/pull/10364#discussion_r3606350967
##########
parquet/src/column/writer/mod.rs:
##########
@@ -1649,12 +1649,16 @@ fn update_max<T: ParquetValueType>(descr:
&ColumnDescriptor, val: &T, max: &mut
update_stat::<T, _>(descr, val, max, |cur| compare_greater(descr, val,
cur))
}
-#[inline]
-#[allow(clippy::eq_op)]
fn is_nan<T: ParquetValueType>(descr: &ColumnDescriptor, val: &T) -> bool {
+ is_nan_with(descr.logical_type_ref(), val)
+}
+
+#[inline(always)]
+#[allow(clippy::eq_op)]
+fn is_nan_with<T: ParquetValueType>(logical_type_ref: Option<&LogicalType>,
val: &T) -> bool {
Review Comment:
I don't think the compare_greater/is_nan changes are really relevant to this
PR, and will conflict with work already in progress to revamp NaN handling per
changes to the spec (#9619). We can revisit once that merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
