alamb commented on issue #200:
URL: https://github.com/apache/arrow-rs/issues/200#issuecomment-841423524


   > @Dandandan @jorgecarleitao @alamb Let me know what you think - is the 
simplification of reading arrow arrays using a single, iterator-based 
abstraction worth a performance hit in a small number of cases (given the 
performance improvement in most cases, especially strings and NULLs). Should I 
create a PR for this work next or should I try to make it even faster or even 
try to replace the Iterators with async Streams before creating a PR?
   
   
   I don't have much of an opinion to add here. I think given the work you have 
put in to date preparing for merging is probably what I would do next (to avoid 
this drifting too far)
   
   Most of the benchmarks look good to me. if anyone else is concerned about 
the slowdown in `read Int32Array, dictionary encoded, mandatory, no NULLs` we 
could always profile it and see where the time was going / optimize just that 
case specifically. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to