alamb commented on a change in pull request #273:
URL: https://github.com/apache/arrow-rs/pull/273#discussion_r632724899
##########
File path: arrow/src/util/display.rs
##########
@@ -217,6 +231,9 @@ pub fn array_value_to_string(column: &array::ArrayRef, row:
usize) -> Result<Str
DataType::Float16 => make_string!(array::Float32Array, column, row),
DataType::Float32 => make_string!(array::Float32Array, column, row),
DataType::Float64 => make_string!(array::Float64Array, column, row),
+ DataType::Decimal(_, scale) => {
+ make_string_from_decimal!(array::DecimalArray, column, row, scale)
Review comment:
I agree it can be a function (rather than a macro) but that can always
be done as a follow on PR. I think this is a good step. 👍
##########
File path: arrow/src/util/display.rs
##########
@@ -217,6 +231,9 @@ pub fn array_value_to_string(column: &array::ArrayRef, row:
usize) -> Result<Str
DataType::Float16 => make_string!(array::Float32Array, column, row),
DataType::Float32 => make_string!(array::Float32Array, column, row),
DataType::Float64 => make_string!(array::Float64Array, column, row),
+ DataType::Decimal(_, scale) => {
+ make_string_from_decimal!(array::DecimalArray, column, row, scale)
Review comment:
I agree it can be a function (rather than a macro) but that can always
be done as a follow on PR. I think this PR is a good step forward. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
