alamb commented on a change in pull request #303: URL: https://github.com/apache/arrow-datafusion/pull/303#discussion_r632737073
########## File path: datafusion/src/physical_plan/functions.rs ########## @@ -1373,20 +1370,26 @@ impl PhysicalExpr for ScalarFunctionExpr { } fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> { - // evaluate the arguments - let inputs = self - .args - .iter() - .map(|e| e.evaluate(batch)) - .collect::<Result<Vec<_>>>()?; + // evaluate the arguments, if there are no arguments we'll instead pass in a null array of + // batch size (as a convention) + let inputs = match self.args.len() { + 0 => vec![ColumnarValue::Array(Arc::new(NullArray::new( Review comment: So I think the plan should be merge https://github.com/apache/arrow-datafusion/pull/328 and then rebase this PR to pick up that change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org