raulcd commented on code in PR #50577:
URL: https://github.com/apache/arrow/pull/50577#discussion_r3628923958
##########
ci/scripts/python_wheel_xlinux_build.sh:
##########
@@ -33,7 +33,8 @@ function check_arrow_visibility {
fi
grep ' T ' nm_arrow.log | grep -v -E "${allowed_symbols}" | cat - >
visible_symbols.log
- if [[ -f visible_symbols.log && `cat visible_symbols.log | wc -l` -eq 0
]]; then
+ # Return early if the log file exists but is empty.
+ if [[ -f visible_symbols.log && ! -s visible_symbols.log ]]; then
Review Comment:
I've just learnt about the `-f` && `! -s` combo, nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
