pitrou commented on code in PR #50281:
URL: https://github.com/apache/arrow/pull/50281#discussion_r3636431077
##########
cpp/src/arrow/util/bit_run_reader.h:
##########
@@ -536,5 +544,93 @@ inline void VisitSetBitRunsVoid(const
std::shared_ptr<Buffer>& bitmap, int64_t o
std::forward<Visit>(visit));
}
+template <typename Visit>
+inline Status VisitTwoSetBitRuns(const uint8_t* left_bitmap, int64_t
left_offset,
+ const uint8_t* right_bitmap, int64_t
right_offset,
+ int64_t length, Visit&& visit,
+ MemoryPool* pool = default_memory_pool()) {
Review Comment:
The `MemoryPool` argument can be removed from all those functions since
AFAICT it's not being used.
##########
cpp/src/arrow/util/bit_run_reader.h:
##########
@@ -17,15 +17,23 @@
#pragma once
+#include <algorithm>
+#include <array>
#include <bit>
#include <cassert>
#include <cstdint>
#include <cstring>
#include <string>
+#include <utility>
+#include "arrow/buffer.h"
+#include "arrow/memory_pool.h"
Review Comment:
These two inclusions are probably not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
