Rich-T-kid commented on PR #10317: URL: https://github.com/apache/arrow-rs/pull/10317#issuecomment-5058819085
> > > It uses an opaque struct rather than an enum, which means we are more free to adjust implementation without changing internals, making it a breaking api change. > > it just came to mind that we can mark this enum as #[non_exhaustive] > the error set is probably bounded enough to not require this i think? i.e. how many more error types would be possible in this context, to warrant this for the future this is also true, no other error cases come to mind right now. ill revert the `#[non_exhaustive]` unless anyone feels strongly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
