kou commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3642987017
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
set(ARROW_WITH_AZURE_SDK ON)
endif()
+if(APPLE
Review Comment:
`APPLE` is redundant. `AppleClang` is available only on Apple.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
set(ARROW_WITH_AZURE_SDK ON)
endif()
+if(APPLE
+ AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
+ AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")
Review Comment:
Could you check this only when `ARROW_JSON=ON`?
```suggestion
if(ARROW_JSON
AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")
```
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
set(ARROW_WITH_AZURE_SDK ON)
endif()
+if(APPLE
+ AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
+ AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")
+ message(STATUS "Disabling ARROW_JSON for AppleClang < 22")
+ set(ARROW_JSON
+ OFF
+ CACHE BOOL "" FORCE)
Review Comment:
We can treat `ARROW_JSON` as a normal variable.
```suggestion
set(ARROW_JSON OFF)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
