JakeDern commented on code in PR #10128:
URL: https://github.com/apache/arrow-rs/pull/10128#discussion_r3653679552


##########
arrow-ipc/src/writer.rs:
##########
@@ -1890,7 +1954,7 @@ fn write_body_buffers<W: Write>(
 
 /// Write a record batch to the writer, writing the message size before the 
message
 /// if the record batch is being written to a stream
-fn write_continuation<W: Write>(
+fn write_continuation_and_meta_size<W: Write>(

Review Comment:
   I updated the function name because I don't think it's accurate. It writes 
both the continuation marker and the metadata size, not just the continuation 
marker.
   
   Updated the comment, if you think I should revert the function name change 
then that's fine too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to