Reranko05 commented on PR #50568: URL: https://github.com/apache/arrow/pull/50568#issuecomment-5104663293
@pitrou @rok @kou I ran into a Windows Unity build failure after this PR. The errors were all from `reader_test.cc`, where unqualified `internal:: `references (`checked_cast`, `Executor`, `UnwrapOrRaise`, `ThreadPool`) were resolved as `arrow::json::internal`. As a debugging experiment, I qualified them as `arrow::internal::...`, and the Windows Unity build passed. Since my PR doesn't modify `reader_test.cc`, I'm not sure whether this indicates a latent issue in the test or a Unity/MSVC-specific lookup interaction. Would you prefer that I include those qualifications in this PR, or is there another approach you'd recommend? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
