Rich-T-kid commented on code in PR #10399:
URL: https://github.com/apache/arrow-rs/pull/10399#discussion_r3666747698
##########
arrow/benches/boolean_kernels.rs:
##########
@@ -79,5 +79,39 @@ fn add_benchmark(c: &mut Criterion) {
c.bench_function("not_slice_24", |b| b.iter(||
bench_not(&array1_sliced_24)));
}
-criterion_group!(benches, add_benchmark);
+fn add_take_n_true_benchmark(c: &mut Criterion) {
+ let size = 2usize.pow(13); // 8K
Review Comment:
Also, as [hhhizzz](https://github.com/hhhizzz) mentioned
[here](https://github.com/apache/arrow-rs/pull/10397#issuecomment-5030552974),
it might be worth benchmarking both small and larger sizes -- say, 32KB and
64KB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
