fallintoplace opened a new pull request, #1049:
URL: https://github.com/apache/arrow-go/pull/1049
## Summary\n\n- return errors from multipath level builder construction
instead of reporting a successful column write\n- release builders created for
earlier chunks when a later chunk fails\n- release partially initialized
builder state on visitor errors\n\n## Testing\n\n- --- FAIL:
TestArrowReaderAdHocReadDecimals (0.00s)
panic: please point PARQUET_TEST_DATA env var to the test data directory
[recovered, repanicked]
goroutine 1687 [running]:
testing.tRunner.func1.2({0x10685d900, 0x106ad67d0})
/opt/homebrew/Cellar/go/1.26.3/libexec/src/testing/testing.go:1974
+0x1a0
testing.tRunner.func1()
/opt/homebrew/Cellar/go/1.26.3/libexec/src/testing/testing.go:1977
+0x318
panic({0x10685d900?, 0x106ad67d0?})
/opt/homebrew/Cellar/go/1.26.3/libexec/src/runtime/panic.go:860 +0x12c
github.com/apache/arrow-go/v18/parquet/pqarrow_test.getDataDir(...)
/Users/hoangvu/Code/OSS/arrow-go-pqarrow-error/parquet/pqarrow/file_reader_test.go:45
github.com/apache/arrow-go/v18/parquet/pqarrow_test.TestArrowReaderAdHocReadDecimals(0x6e0115938908)
/Users/hoangvu/Code/OSS/arrow-go-pqarrow-error/parquet/pqarrow/file_reader_test.go:62
+0x220
testing.tRunner(0x6e0115938908, 0x106ad1cc8)
/opt/homebrew/Cellar/go/1.26.3/libexec/src/testing/testing.go:2036 +0xc4
created by testing.(*T).Run in goroutine 1
/opt/homebrew/Cellar/go/1.26.3/libexec/src/testing/testing.go:2101
+0x3a8
FAIL github.com/apache/arrow-go/v18/parquet/pqarrow 1.381s
FAIL\n\nThe regression test uses a valid dictionary chunk followed by a
dictionary containing a null, which reaches the previously swallowed error path
and verifies checked allocator cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
