prmoore77 commented on code in PR #4634:
URL: https://github.com/apache/arrow-adbc/pull/4634#discussion_r3679998036
##########
.github/workflows/javascript.yml:
##########
@@ -169,18 +173,35 @@ jobs:
name: bindings-${{ matrix.settings.target }}
path: javascript
- name: Setup conda (Windows)
- if: runner.os == 'Windows'
+ # Miniforge does not publish a Windows ARM64 installer, so the ARM64
+ # leg gets SQLite from vcpkg below instead.
+ if: runner.os == 'Windows' && runner.arch != 'ARM64'
uses:
conda-incubator/setup-miniconda@8ee1f361103df19b6f8c8655fd3967a8ecb162d5 #
v4.0.1
with:
miniforge-version: latest
- name: Install C++ dependencies (Windows)
- if: runner.os == 'Windows'
+ if: runner.os == 'Windows' && runner.arch != 'ARM64'
run: conda install -c conda-forge --file ci/conda_env_cpp.txt
+ - name: Install C++ dependencies (Windows ARM64)
+ if: runner.os == 'Windows' && runner.arch == 'ARM64'
+ shell: pwsh
+ run: |
+ if (-not $env:VCPKG_INSTALLATION_ROOT) {
+ git clone --depth 1 https://github.com/microsoft/vcpkg.git
"$env:RUNNER_TEMP\vcpkg"
+ & "$env:RUNNER_TEMP\vcpkg\bootstrap-vcpkg.bat"
+ echo "VCPKG_INSTALLATION_ROOT=$env:RUNNER_TEMP\vcpkg" >>
$env:GITHUB_ENV
+ $vcpkgRoot = "$env:RUNNER_TEMP\vcpkg"
+ } else {
+ $vcpkgRoot = $env:VCPKG_INSTALLATION_ROOT
+ }
+ & "$vcpkgRoot\vcpkg.exe" install sqlite3:arm64-windows-static-md
+ $toolchain = "$vcpkgRoot\scripts\buildsystems\vcpkg.cmake" -replace
'\\', '/'
+ echo "ADBC_CMAKE_ARGS=-DCMAKE_TOOLCHAIN_FILE=$toolchain
-DVCPKG_TARGET_TRIPLET=arm64-windows-static-md" >> $env:GITHUB_ENV
Review Comment:
This is pre-existing behavior shared by every test leg, not specific to
ARM64: all five existing platform packages are also unpublished at 0.25.0,
and npm treats unresolvable optional dependencies as skippable. The ARM64
leg passed CI with the package absent from the registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
