AlenkaF commented on a change in pull request #10334:
URL: https://github.com/apache/arrow/pull/10334#discussion_r633370744
##########
File path: r/R/compute.R
##########
@@ -286,3 +286,8 @@ cast_options <- function(safe = TRUE, ...) {
)
modifyList(opts, list(...))
}
+
+strptime_arrow <- function(..., format, unit){
Review comment:
Got it.
Arrow function uses `format` and `unit` as an FunctionOption if I understand
correctly, haven't found `tz` yet.
I think they should have defaults, yes: `format = "%Y-%m-%d %H:%M:%S"` and
`unit = TimeUnit$MICRO/2L/"us"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
