RabahSend commented on issue #30431: URL: https://github.com/apache/arrow/issues/30431#issuecomment-5131270289
Hi, I’m interested in working on this issue. I checked the current CSV writer implementation, and it looks like configurable escaping is still unsupported at write time. `WriteOptions` already has `quoting_style` and related options such as `eol`, but `writer.cc` still hardcodes double-quote escaping through its `Escape()` helper. I also reviewed the previous work in #11863. That PR was closed without being merged, but @pitrou’s API proposal still seems like the most relevant direction: * `QuotingStyle quoting_style` (already present) * `bool double_quote` * `char escape_char` For context, `ParseOptions` already exposes `double_quote` and `escape_char` for reading, so adding similar options to `WriteOptions` would keep the APIs consistent. Before starting, I’d like to confirm: 1. Is @pitrou’s proposal still the preferred design for the current codebase? 2. How should `readr`’s `escape = "none"` behaviour be represented: should the writer reject values containing quotes, or allow unescaped quotes inside quoted fields? 3. Should this issue initially be limited to the C++ implementation and tests, with language bindings handled separately? If this direction is still relevant, I’d be happy to work on the implementation and regression tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
