Copilot commented on code in PR #4606: URL: https://github.com/apache/arrow-adbc/pull/4606#discussion_r3687459086
########## c/cmake_modules/DefineOptions.cmake: ########## @@ -81,6 +81,14 @@ macro(define_option_string name description default) endif() endmacro() +# On Windows, we can't build both static and shared (they both generate a .lib), so disable static build Review Comment: The comment says this “disable[s] static build”, but the code only changes the default to OFF on Windows; users can still enable a static-only build (or disable shared) without conflict. Please reword the comment so it matches the actual behavior. This issue also appears in the following locations of the same file: - line 90 - line 266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
